Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Fonts Report (Priority level: High) #7

Open
EstherMoellman opened this issue Jul 7, 2020 · 14 comments
Open

Broken Fonts Report (Priority level: High) #7

EstherMoellman opened this issue Jul 7, 2020 · 14 comments
Labels
bug Something isn't working Critical

Comments

@EstherMoellman
Copy link

EstherMoellman commented Jul 7, 2020

No description provided.

@EstherMoellman
Copy link
Author

EstherMoellman commented Jul 26, 2020

At: https://i.reddit.com/r/FirefoxCSS/comments/hxybh7/can_someone_help_a_noob_i_just_installed_the/.compact

if you click the image link: https://i.redd.it/0efowtlou3d51.png

Then the message appears: The image "https://i.redd.it/0efowtlou3d51.png" cannot be displayed because it contains errors.

If you disable UltimaDark... everything works fine.
I also tested same link on www.reddit and old.reddit, and the issue still appears when UltimaDark is enabled.

FIXED V1.2.6

@ThomazPom
Copy link
Owner

A lot of contrast issues you may encounter for the time being are due to a whole part of the code that i disabled to work on others issues.

@ThomazPom
Copy link
Owner

ThomazPom commented Aug 3, 2020

https://tpeweb.paybox.com/cgi/MYpagepaiement.cgi
FIXED V1.2.5
REGRESSION V.1.2.6
FIXED V1.2.8

Repository owner deleted a comment from ThomazPom Aug 29, 2020
Repository owner deleted a comment from ThomazPom Aug 31, 2020
@Vintagemotors Vintagemotors added the bug Something isn't working label Dec 30, 2023
@Vintagemotors Vintagemotors pinned this issue Dec 30, 2023
@barolo
Copy link

barolo commented Apr 23, 2024

This is still an issue, anything with Cyrillic script [like Ukrainian] gets converted into garbage.
Latest Firefox.

Screenshot_20240423_221735

@barolo
Copy link

barolo commented Apr 24, 2024

Also broken on some Polish sites, for example:
https://trojmiasto.wyborcza.pl/trojmiasto/0,0.html
Screenshot_20240424-025741646

@Vintagemotors
Copy link
Collaborator

Vintagemotors commented Jun 22, 2024

Looks like an ANSI encoding issue. (Not really a font issue though since the font itself looks fine)

@Vintagemotors
Copy link
Collaborator

I don't speak either language but I spot checked text on the site you linked and a national Ukrainian news site with google translate and the style appeared to be consistent throughout without any weird encoding like you saw there - again assuming it was something to do with ANSI to UTF-8 not being handled properly or some other semi-proprietary encoding scheme causing a conflict (as of 1.5.50) @barolo

@barolo
Copy link

barolo commented Aug 26, 2024

I don't speak either language but I spot checked text on the site you linked and a national Ukrainian news site with google translate and the style appeared to be consistent throughout without any weird encoding like you saw there - again assuming it was something to do with ANSI to UTF-8 not being handled properly or some other semi-proprietary encoding scheme causing a conflict (as of 1.5.50) @barolo

Unfortunately, as of 1.50.50 still an issue, all Polish letters with diactrics (like Ł, ł, ó, ź, ą, ę) are garbled with this add-on enabled.
Screenshot_20240826-123710375

@Vintagemotors
Copy link
Collaborator

Vintagemotors commented Aug 29, 2024

@barolo upon closer inspection of your screenshots which I initially assumed were taken using Firefox's "Responsive Design Mode" you appear to be on mobile which is highly experimental and unsupported. As stated in the wiki, it "somewhat works" with a single browser that (to my knowledge) isn't even published in any app stores. The flag which allows download from mobile is turned on for testing purposes but given how many features are missing from most mobile Firefox builds that UltimaDark relies on it will never be fully compatible unless mobile reaches feature parity. Please only submit issues for things that affect both desktop and mobile as many mobile only issues are essentially either unfixable or would take an unreasonable amount of work.

Screenshot(desktop)

image

@ThomazPom
Copy link
Owner

1.5.71:
I’ve fixed the issue with pages using non-UTF-8 charsets. Instead of forcing the page into UTF-8, which caused all kinds of issues, I now just let the page keep its original charset. I’m using a hacky but effective method to still write in UTF-8 without messing with the page’s encoding. This avoids the trouble of re-encoding into incompatible charsets. There’s still a potential issue if the page explicitly uses the charset keyword in CSS (not verified), or the content property in CSS (not verified), but this should be rare enough not to worry about.

I think it was the source of this issue too.

@barolo
Copy link

barolo commented Oct 16, 2024

1.5.71: I’ve fixed the issue with pages using non-UTF-8 charsets. Instead of forcing the page into UTF-8, which caused all kinds of issues, I now just let the page keep its original charset. I’m using a hacky but effective method to still write in UTF-8 without messing with the page’s encoding. This avoids the trouble of re-encoding into incompatible charsets. There’s still a potential issue if the page explicitly uses the charset keyword in CSS (not verified), or the content property in CSS (not verified), but this should be rare enough not to worry about.

I think it was the source of this issue too.

Can confirm, fixed my issues.

@ThomazPom
Copy link
Owner

ThomazPom commented Oct 27, 2024

1.5.71 to 1.5.76 (current) were dedicated to fixing non utf8 websites. Fonts and CSSes are now loaded in their original encoding, eliminating the content keyword issue.

@rr1231234
Copy link

rr1231234 commented Nov 7, 2024

https://www.wsj.com/ - first visit (or after a while) shows the slightly wrong font (wider than normal) but hitting F5 will fix it and showing the true font of that site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical
Projects
Status: Currently Resolved
Development

No branches or pull requests

5 participants