Issue305 | Add Topic Configurations #19
Conversation
|
Any update on this? I think the Topology Builder change is quite necessary |
|
+1 on this, I would also like to see this change implemented. The current TopologyBuilder does not allow for wildcard matching on topic exchanges. |
|
Unfortunately, I no longer use amqp, which is why I'm not putting much effort into it at the moment. However, the merge is currently not down to me but to the lack of a review, if I can see that correctly. |
|
@m110 is it possible to get a review on this PR? I see no way currently with the package to use RabbitMQ topic exchanges with wildcard routing key matching. |
| type TopologyBuilder interface { | ||
| BuildTopology(channel *amqp.Channel, queueName string, exchangeName string, config Config, logger watermill.LoggerAdapter) error | ||
| BuildTopology(channel *amqp.Channel, queueName string, exchangeName string, routingKey string, config Config, logger watermill.LoggerAdapter) error |
There was a problem hiding this comment.
This changes the public interface, so we would need to bump the major version to do this.
There was a problem hiding this comment.
That is absolutely correct. Do you have a suggestion on how to solve the routing problem without breaking change? Otherwise, the only solution would be to create your own TopologyBuilder and set an internal variable before each BuildTopology call.
On the other hand, is the handling of routing within the BuildTopology function not so wrong?
For me at least, the PR would no longer be a priority because we have switched to another broker, but the problem seems to exist due to the requests from other developers
Co-authored-by: Miłosz Smółka <[email protected]>
Fix ThreeDotsLabs/watermill#305
Rework the TopologyBuilder to accept individual QueueBinding namings (TopologyBuilder Interface Change!)
Add configurations for topic routing
@m110 can you please review and approve this PR?