Skip to content

Commit

Permalink
github: test: Disable VNU tests. Unknown if these are still relevant
Browse files Browse the repository at this point in the history
Disable these tests as TBC as to whether they are relevant and also rely on direct source_url query which is no longer supported
  • Loading branch information
michaelwood committed Oct 3, 2024
1 parent 14b4e8e commit b87fbb5
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,14 @@ jobs:
- name: Compile Messages
run: DJANGO_SETTINGS_MODULE=cove_project.settings python ./cove/manage.py compilemessages

- name: Install vnu
run: cd cove; wget "https://github.com/validator/validator/releases/download/16.3.3/vnu.jar_16.3.3.zip"; unzip vnu.jar_16.3.3.zip
- name: VNU tests
run: "cd cove; DJANGO_SETTINGS_MODULE=cove_project.settings DEBUG=false ALLOWED_HOSTS=localhost python manage.py runserver & (sleep 10s; java -jar dist/vnu.jar 'http://localhost:8000/' 'http://localhost:8000/?source_url=https://github.com/threesixtygiving/dataquality/raw/master/cove/cove_360/fixtures/fundingproviders_grants_2_grants.csv
' 'http://localhost:8000/?source_url=https://github.com/threesixtygiving/dataquality/raw/main/cove/cove_360/fixtures/badfile_all_validation_errors.xlsx
' 'http://localhost:8000/?source_url=https://github.com/threesixtygiving/dataquality/raw/main/cove/cove_360/fixtures/badfile_all_validation_errors.json
' 'http://localhost:8000/common_errors/' 'http://localhost:8000/additional_checks/')"
# Disable these tests as TBC as to whether they are relevant and also rely on direct source_url query which is no longer supported
# - name: Install vnu
# run: cd cove; wget "https://github.com/validator/validator/releases/download/16.3.3/vnu.jar_16.3.3.zip"; unzip vnu.jar_16.3.3.zip
# - name: VNU tests
# run: "cd cove; DJANGO_SETTINGS_MODULE=cove_project.settings DEBUG=false ALLOWED_HOSTS=localhost python manage.py runserver & (sleep 10s; java -jar dist/vnu.jar 'http://localhost:8000/' 'http://localhost:8000/?source_url=https://github.com/threesixtygiving/dataquality/raw/master/cove/cove_360/fixtures/fundingproviders_grants_2_grants.csv
# ' 'http://localhost:8000/?source_url=https://github.com/threesixtygiving/dataquality/raw/main/cove/cove_360/fixtures/badfile_all_validation_errors.xlsx
# ' 'http://localhost:8000/?source_url=https://github.com/threesixtygiving/dataquality/raw/main/cove/cove_360/fixtures/badfile_all_validation_errors.json
# ' 'http://localhost:8000/common_errors/' 'http://localhost:8000/additional_checks/')"
# - name: Report to coveralls
# env:
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down

0 comments on commit b87fbb5

Please sign in to comment.