Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issues related to the GDI-DE compliance. #2

Closed
wants to merge 2 commits into from

Conversation

ahmdthr
Copy link

@ahmdthr ahmdthr commented Nov 2, 2023

The current generated ISO metadata conforms to the ISO-19139 standards, but fails the GDI-DE compliance. This PR aims to fix the GDI-DE compliance issues.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

… because the GDI compliance required to have maximum one 'MD_LegalConstraints' with 'useConstraints' field.
@ahmdthr ahmdthr marked this pull request as ready for review November 14, 2023 04:18
@ridoo
Copy link

ridoo commented Nov 20, 2023

@ahmdthr As discussed last week: Move the fixes to thuenen_atlas project. Let's decide in the Sprint meeting today to make upstream issue plus PR or not.

@ahmdthr ahmdthr closed this Nov 23, 2023
@ahmdthr ahmdthr deleted the feature/gdi-de-compliance branch November 23, 2023 07:49
@ridoo
Copy link

ridoo commented Nov 23, 2023

Will be merged into thuenen_atlas: https://github.com/Thuenen-GeoNode-Development/Sprints/issues/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants