Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DiffEqCallBack compat #223

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

sharanry
Copy link
Contributor

@sharanry sharanry commented Jun 20, 2024

Resolves #222

@ThummeTo
Copy link
Owner

looks (action error log) like some dependencies need to be relaxed a little ...

fail-fast=false, so Julia v1 tests are triggered too
added FMIZoo compat to use old version
duplicated [compat] - my bad
@ThummeTo
Copy link
Owner

  • Tests Julia v1.6 (Win/Linux) fail because of unresolvable dependencies, so we can (a) relax dependencies or (b) pull Julia dep to 1.9 (I guess you are not using the 1.6 LTS anyway, do you?)
  • Test Julia v1.10 (Linux) fails with 1 error, because of a missing Linux FMU in FMIZoo (that is ok IMO)
  • Test Julia v.10 (Windows) succeeded

@sharanry
Copy link
Contributor Author

Yes. I am using Julia 1.10. So the 1.6 failure shouldn't matter. Also 1.11 is expected to be the new LTS. So this shouldn't be a problem shortly.

pulled Julia compat to 1.9+
@ThummeTo
Copy link
Owner

Do you want to do additional tests or are we ready to release?

@ChrisRackauckas
Copy link

Note this should be safe since the break was in manifold projection callbacks which aren't used here.

@sharanry
Copy link
Contributor Author

Do you want to do additional tests or are we ready to release?

I am good to do a release.

@ThummeTo ThummeTo merged commit 6b76976 into ThummeTo:v0.10.4 Jun 20, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants