Type stability for StringToValueReference #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for noticing, we will do a complete check with DispatchDoctor.jl in all libraries. Some FMUs (e.g. Dymola) start counting at higher values... returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmi2StringToValueReferencehas a type instability where it can return either aUInt32or aNothingtype result.This gives some impracticalities when for example broadcasting where you can get either a
Vector{UInt32}or aVector{Union{Nothing,UInt32}}depending on the input. This pull-request fixes that by returningtypemax(UInt32)(= 4.3e9) by default.(If your model has more than 4.3e9 inputs then this will fail, but I don't think this edge case is realistic)