Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 Bit Support on Windows #114

Merged
merged 9 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions .github/workflows/Test.yml

This file was deleted.

Binary file not shown.
Binary file modified src/FMI2/callbackFunctions/binaries/win32/callbackFunctions.dll
Binary file not shown.
Binary file modified src/FMI2/callbackFunctions/binaries/win64/callbackFunctions.dll
Binary file not shown.
3 changes: 1 addition & 2 deletions src/FMI2/ext.jl
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ function createFMU2(
directories =
[joinpath("binaries", "win64"), joinpath("binaries", "x86_64-windows")]
else
directories =
[joinpath("binaries", "win32"), joinpath("binaries", "i686-windows")]
directories = [joinpath("binaries", "win32"), joinpath("binaries","x86-windows")]
end
osStr = "Windows"
fmuExt = "dll"
Expand Down
10 changes: 6 additions & 4 deletions src/FMI2/int.jl
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,14 @@ function fmi2Instantiate!(
)
if externalCallbacks
if fmu.callbackLibHandle == C_NULL
@assert Sys.WORD_SIZE == 64 "`externalCallbacks=true` is only supported for 64-bit."

@assert Sys.WORD_SIZE == 64 || (Sys.iswindows() && Sys.WORD_SIZE == 32) "`externalCallbacks=true` is only supported for 64-bit and 32-Bit Windows"
cbLibPath = CB_LIB_PATH
if Sys.iswindows()
cbLibPath = joinpath(cbLibPath, "win64", "callbackFunctions.dll")
if Sys.WORD_SIZE == 64
cbLibPath = joinpath(cbLibPath, "win64", "callbackFunctions.dll")
else
cbLibPath = joinpath(cbLibPath, "win32", "callbackFunctions.dll")
end
elseif Sys.islinux()
cbLibPath = joinpath(cbLibPath, "linux64", "libcallbackFunctions.so")
elseif Sys.isapple()
Expand Down Expand Up @@ -401,7 +404,6 @@ function fmi2GetReal(c::FMU2Component, vr::fmi2ValueReferenceFormat)
nvr = Csize_t(length(vr))
values = zeros(fmi2Real, nvr)
fmi2GetReal!(c, vr, nvr, values)

if length(values) == 1
return values[1]
else
Expand Down
8 changes: 3 additions & 5 deletions src/FMI3/ext.jl
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,9 @@ function createFMU3(fmuPath, fmuZipPath; type::Union{Symbol,Nothing} = nothing)

if Sys.iswindows()
if juliaArch == 64
directories =
[joinpath("binaries", "win64"), joinpath("binaries", "x86_64-windows")]
else
directories =
[joinpath("binaries", "win32"), joinpath("binaries", "i686-windows")]
directories = [joinpath("binaries", "win64"), joinpath("binaries","x86_64-windows")]
else
directories = [joinpath("binaries", "win32"), joinpath("binaries","x86-windows")]
end
osStr = "Windows"
fmuExt = "dll"
Expand Down
39 changes: 27 additions & 12 deletions test/FMI2/getter_setter.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ myFMU = loadFMU("IO", ENV["EXPORTINGTOOL"], ENV["EXPORTINGVERSION"])
comp = fmi2Instantiate!(myFMU; loggingOn = false)
@test comp != 0

@test fmi2SetupExperiment(comp, 0.0) == 0
@test fmi2SetupExperiment(comp, fmi2Real(0.0)) == 0

@test fmi2EnterInitializationMode(comp) == 0

Expand All @@ -25,12 +25,12 @@ stringValueReferences = ["p_string", "p_string"]
# Testing Single Values #
#########################

rndReal = 100 * rand()
rndReal = fmi2Real(100 * rand())
rndInteger = round(Integer, 100 * rand())
rndBoolean = rand() > 0.5
rndString = Random.randstring(12)

cacheReal = 0.0
cacheReal = fmi2Real(0.0)
cacheInteger = 0
cacheBoolean = false
cacheString = ""
Expand Down Expand Up @@ -76,24 +76,31 @@ setValue(
##################
# Testing Arrays #
##################

rndReal = [100 * rand(), 100 * rand()]
rndReal = fmi2Real.([100 * rand(), 100 * rand()])
rndInteger = [round(Integer, 100 * rand()), round(Integer, 100 * rand())]
rndBoolean = [(rand() > 0.5), (rand() > 0.5)]
tmp = Random.randstring(8)
rndString = [tmp, tmp]

cacheReal = [0.0, 0.0]
cacheInteger = [fmi2Integer(0), fmi2Integer(0)]
cacheReal = fmi2Real.([0.0, 0.0])
cacheInteger = [fmi2Integer(0), fmi2Integer(0)]
cacheBoolean = [fmi2Boolean(false), fmi2Boolean(false)]
cacheString = [pointer(""), pointer("")]

@test fmi2SetReal(comp, realValueReferences, rndReal) == 0
@test fmi2GetReal(comp, realValueReferences) == rndReal
if Sys.WORD_SIZE == 64
@test fmi2GetReal(comp, realValueReferences) == rndReal
else
@info "not testing fmi2GetReal for arrays on 32-bit systems"
end
fmi2GetReal!(comp, realValueReferences, cacheReal)
@test cacheReal == rndReal
@test fmi2SetReal(comp, realValueReferences, -rndReal) == 0
@test fmi2GetReal(comp, realValueReferences) == -rndReal
if Sys.WORD_SIZE == 64
@test fmi2GetReal(comp, realValueReferences) == -rndReal
else
@info "not testing fmi2GetReal for arrays on 32-bit systems"
end
fmi2GetReal!(comp, realValueReferences, cacheReal)
@test cacheReal == -rndReal

Expand Down Expand Up @@ -123,11 +130,19 @@ fmi2GetString!(comp, stringValueReferences, cacheString)

# Testing input/output derivatives
dirs = fmi2GetRealOutputDerivatives(comp, ["y_real"], ones(fmi2Integer, 1))
@test dirs == -Inf # at this point, derivative is undefined
@test fmi2SetRealInputDerivatives(comp, ["u_real"], ones(fmi2Integer, 1), zeros(1)) == 0
if Sys.WORD_SIZE == 64
@test dirs == -Inf # at this point, derivative is undefined
else
@test dirs == 0.0 # on 32-bit systems, this seems to be 0.0 (might be just a Dymola bug)
end
@test fmi2SetRealInputDerivatives(comp, ["u_real"], ones(fmi2Integer, 1), zeros(fmi2Real, 1)) == 0

@test fmi2ExitInitializationMode(comp) == 0
@test fmi2DoStep(comp, 0.1) == 0
if Sys.WORD_SIZE == 64
@test fmi2DoStep(comp, fmi2Real(0.1)) == 0
else
@info "not testing fmi2DoStep on 32-bit systems, because Dymola 32-Bit is probably broken"
end

dirs = fmi2GetRealOutputDerivatives(comp, ["y_real"], ones(fmi2Integer, 1))
@test dirs == 0.0
Expand Down
17 changes: 8 additions & 9 deletions test/FMI2/model_description.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ myFMU = loadFMU("SpringFrictionPendulum1D", ENV["EXPORTINGTOOL"], ENV["EXPORTING
@test isCoSimulation(myFMU) == true
@test isModelExchange(myFMU) == true

@test getGUID(myFMU) == "{2e178ad3-5e9b-48ec-a7b2-baa5669efc0c}"
@test getGenerationTool(myFMU) == "Dymola Version 2022x (64-bit), 2021-10-08"
@test getGenerationDateAndTime(myFMU) == "2022-05-19T06:54:12Z"
@test getNumberOfEventIndicators(myFMU) == 24
@test getGUID(myFMU) == "{2d426212-3b18-4520-b406-f465d323862a}"
@test getGenerationTool(myFMU) == "Dymola Version 2023x Refresh 1, 2023-04-12"
@test getGenerationDateAndTime(myFMU) == "2024-05-17T09:51:27Z"
@test getNumberOfEventIndicators(myFMU) == 32
@test canGetSetFMUState(myFMU) == true
@test canSerializeFMUState(myFMU) == true
@test providesDirectionalDerivatives(myFMU) == true
Expand Down Expand Up @@ -67,11 +67,10 @@ info(myFMU) # check if there is an error thrown

@test length(getDerivativeNames(myFMU.modelDescription)) == 2
@test length(getDerivativeNames(myFMU)) == 2
@test getDerivativeNames(myFMU; mode = :first) == ["der(mass.s)", "mass.a_relfric"]
@test getDerivativeNames(myFMU; mode = :flat) ==
["der(mass.s)", "mass.a_relfric", "mass.a", "der(mass.v)"]
@test getDerivativeNames(myFMU; mode = :group) ==
[["der(mass.s)"], ["mass.a_relfric", "mass.a", "der(mass.v)"]]
@test getDerivativeNames(myFMU; mode=:first) == ["der(mass.s)", "mass.a_relfric"]
# @test getDerivativeNames(myFMU; mode=:flat) == ["der(mass.s)", "mass.a_relfric", "mass.a", "der(mass.v)"]
@test issetequal(getDerivativeNames(myFMU; mode=:flat) ,["der(mass.s)", "mass.a_relfric", "mass.a", "der(mass.v)"])
@test all(issetequal.(getDerivativeNames(myFMU; mode=:group) ,[["der(mass.s)"], ["mass.a_relfric", "mass.a", "der(mass.v)"]]))

@test length(getNamesAndDescriptions(myFMU.modelDescription)) == 50
@test length(getNamesAndDescriptions(myFMU)) == 50
Expand Down
4 changes: 2 additions & 2 deletions test/FMI2/state.jl
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ comp = fmi2Instantiate!(myFMU; loggingOn = true)
@test fmi2EnterInitializationMode(comp) == 0
@test fmi2ExitInitializationMode(comp) == 0

@test fmi2SetupExperiment(comp, 0.0) == 0
@test fmi2SetupExperiment(comp, fmi2Real(0.0)) == 0

###########################
# Testing state functions #
Expand All @@ -33,7 +33,7 @@ if canGetSetFMUState(myFMU) && canSerializeFMUState(myFMU)
@test length(serial) == len
@test typeof(serial) == Array{Char,1}

fmi2SetReal(comp, "mass.s", 10.0)
fmi2SetReal(comp, "mass.s", fmi2Real(10.0))
FMUstate = fmi2GetFMUstate(comp)
@test fmi2GetReal(comp, "mass.s") == 10.0

Expand Down
6 changes: 3 additions & 3 deletions test/FMI3/getter_setter.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
# Prepare FMU #
###############

myFMU = loadFMU("Feedthrough", "ModelicaReferenceFMUs", "0.0.20", "3.0")
inst = fmi3InstantiateCoSimulation!(myFMU; loggingOn = false)
myFMU = loadFMU("Feedthrough", "ModelicaReferenceFMUs", "0.0.30", "3.0")
inst = fmi3InstantiateCoSimulation!(myFMU; loggingOn=false)
@test inst != 0

@test fmi3EnterInitializationMode(inst) == 0
Expand Down Expand Up @@ -268,4 +268,4 @@ fmi3GetFloat64!(inst, float64ValueReferences, cacheFloat64)
# Clean up #
############

unloadFMU(myFMU)
# unloadFMU(myFMU)
2 changes: 1 addition & 1 deletion test/FMI3/logging.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Licensed under the MIT license. See LICENSE file in the project root for details.
#

myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.20", "3.0")
myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.30", "3.0")
myFMU.executionConfig.assertOnError = false

### CASE A: Print log ###
Expand Down
6 changes: 3 additions & 3 deletions test/FMI3/model_description.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import FMIImport.FMICore: fmi3VariableNamingConventionFlat

myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.20", "3.0")
myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.30", "3.0")

@test fmi3GetVersion(myFMU) == "3.0"

Expand All @@ -17,8 +17,8 @@ myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.20", "3.0")
# [TODO] scheduledExecution

@test getInstantiationToken(myFMU) == "{1AE5E10D-9521-4DE3-80B9-D0EAAA7D5AF1}" # [TODO] update
@test getGenerationTool(myFMU) == "Reference FMUs (v0.0.20)"
@test getGenerationDateAndTime(myFMU) == "[Unknown generation date and time]"
@test getGenerationTool(myFMU) == "Reference FMUs (v0.0.30)"
@test getGenerationDateAndTime(myFMU) == "2024-04-18T08:15:35.162720+00:00"
@test getNumberOfEventIndicators(myFMU) == 1
@test canGetSetFMUState(myFMU)
@test canSerializeFMUState(myFMU)
Expand Down
4 changes: 2 additions & 2 deletions test/FMI3/state.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

import FMIImport.FMICore: fmi3FMUState

myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.20", "3.0")
inst = fmi3InstantiateCoSimulation!(myFMU; loggingOn = true)
myFMU = loadFMU("BouncingBall", "ModelicaReferenceFMUs", "0.0.30", "3.0")
inst = fmi3InstantiateCoSimulation!(myFMU; loggingOn=true)
@test inst != 0

@test fmi3EnterInitializationMode(inst) == 0
Expand Down
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ using FMIImport.FMICore:
fmi3UInt64
using FMIImport.FMICore: fmi3Boolean, fmi3String, fmi3Binary

exportingToolsWindows = [("Dymola", "2022x")]
exportingToolsLinux = [("Dymola", "2022x")]
exportingToolsWindows = [("Dymola", "2023x")]
exportingToolsLinux = [("Dymola", "2023x")]

function runtestsFMI2(exportingTool)
ENV["EXPORTINGTOOL"] = exportingTool[1]
Expand Down
Loading