catch logging.* usage during tests

TicClick · Apr 16, 2021 · c37bf4f · c37bf4f
1 parent f58b6ee
commit c37bf4f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/librarian/main.py b/librarian/main.py
@@ -18,7 +18,6 @@
 
 
 def configure_client(config):
-    # TODO: ban logging.{debug,info,warning,error,critical} which I sometimes call by mistake
     loggers = logging_utils.all_loggers()
     loggers["librarian.main"] = logger  # otherwise an old copy with default settings is kept
     logging_utils.setup_logging(config["runtime"]["dir"], config["logging"], loggers.values())

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -202,3 +202,17 @@ def inner():
 @pytest.fixture
 def assignee_login():
     return "assignee-login"
+
+
+@pytest.fixture(autouse=True)
+def patch_logging(mocker):
+    class WrongLoggingAPIUsedException(Exception):
+        pass
+
+    for method in ("debug", "info", "warning", "error", "critical", "log"):
+        mocker.patch(
+            f"logging.{method}",
+            side_effect=WrongLoggingAPIUsedException(
+                "Attempt to use logging.* methods detected -- check the stacktrace"
+            )
+        )