Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Plugin Translation - Needs to respect the language plugin "dependents" field #8263

Open
pmario opened this issue Jun 15, 2024 · 3 comments · May be fixed by #8435
Open

[BUG] Plugin Translation - Needs to respect the language plugin "dependents" field #8263

pmario opened this issue Jun 15, 2024 · 3 comments · May be fixed by #8435

Comments

@pmario
Copy link
Member

pmario commented Jun 15, 2024

@Jermolene, @linonetwo -- breaking change

German Austria - de-AT and German Germany de-DE are very similar. That's why the de-AT language uses "dependents": ["$:/languages/de-DE"], to install both languages if needed.

I did translate the menu-bar plugin for de-DE but switching to German Austria does not use that info for the menu-bar plugin !!

image

The default language switching works as expected: See "Jannuar" vs "Jänner"

image
@pmario pmario mentioned this issue Jun 15, 2024
Open
@linonetwo
Copy link
Contributor

How does it work for regular translation? Is enable de-AT also enable de-DE ? I thought there will only be one language plugin being enabled.

@pmario
Copy link
Member Author

pmario commented Jun 17, 2024

The PluginSwitcher seems to use it. The accumulatePlugins seems to extract "dependents" first and then the one which is activated.

https://github.com/Jermolene/TiddlyWiki5/blob/91e0b2afb6e6729d9f5f8333a88db83d77133489/core/modules/pluginswitcher.js#L55-L59

@linonetwo
Copy link
Contributor

linonetwo commented Jun 17, 2024 •
edited
Loading

@pmario How to get dependents using fitler? This is not working

$tw.wiki.filterTiddlers('[[$:/languages/]addsuffix[de-AT]get[dependent]]')

Oh, it is dependents

@linonetwo linonetwo mentioned this issue Jun 17, 2024
Closed
@Jermolene Jermolene mentioned this issue Jun 18, 2024
Merged
@linonetwo linonetwo linked a pull request Jul 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pmario @linonetwo