Fix html macro exception missing parameter value #7122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem where a macrocall with an empty parameter causes the RSOD
Also see the discussion at Talk
To preproduce
<<list-links '[tag[HelloThere]]' field:>>
The problem is this line
.createElementNS() allows the second parameter
createElementNS(namespaceURI, qualifiedName)
to be a HTML tag name.In this case
this.tag
->qualifiedName
contains the valuefield:
... where the:
colon throws an exception. ...This PR