Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ViewTemplateBodyFilters.multids For Readability #8592

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kookma
Copy link
Contributor

@kookma kookma commented Sep 12, 2024

This Cascade from

[tag[$:/tags/wiki-test-spec]type[text/vnd.tiddlywiki-multiple]then[$:/core/ui/TestCaseTemplate]] [tag[$:/tags/wiki-test-spec-failing]type[text/vnd.tiddlywiki-multiple]then[$:/core/ui/TestCaseTemplate]]

Simplified. The redundant then[$:/core/ui/TestCaseTemplate] part removed

I also suggest using the same convention for all cascades, e.g. use `":then..." this makes processing cascades in third-party plugins simple.

This Cascade from 

```
[tag[$:/tags/wiki-test-spec]type[text/vnd.tiddlywiki-multiple]then[$:/core/ui/TestCaseTemplate]] [tag[$:/tags/wiki-test-spec-failing]type[text/vnd.tiddlywiki-multiple]then[$:/core/ui/TestCaseTemplate]]
```

Simplified. I also suggest using the same convention for all cascades
Copy link

stackblitz bot commented Sep 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Confirmed: kookma has already signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Thanks @kookma that is a worthwhile improvement

@Jermolene Jermolene merged commit fbf619b into TiddlyWiki:master Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants