Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colour-picker macro in Tag Manager #8606

Merged

Conversation

Leilei332
Copy link
Contributor

@Leilei332 Leilei332 commented Sep 16, 2024

See #8603 .

This require #8605 to display properly.

图片

Copy link

stackblitz bot commented Sep 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Great thanks @Leilei332

@Jermolene Jermolene merged commit a510e4a into TiddlyWiki:master Sep 16, 2024
4 checks passed
@kookma
Copy link
Contributor

kookma commented Sep 16, 2024

@Leilei332
I have tested the new color picker, and it seems there are some issues

1. move mouse on left side of color chooser what is that clickable square?
image

2. Clicking in the input box of color chooser or the button itself closes the drop down

msedge_img_297_20240916

@kookma
Copy link
Contributor

kookma commented Sep 16, 2024

Another issue:
If you set the color of a tag through TagManager using new color macro, it will not correctly be displayed on the tag tiddler.
For example change the color of About tiddler

  1. select a color for About
    image

  2. See the color by editing About tiddler
    image

@Leilei332
Copy link
Contributor Author

Leilei332 commented Sep 16, 2024

  1. move mouse on left side of color chooser what is that clickable square?

This square does have function. After you select a color with the native color or input a valid color in the input field on the left, the square shows the color and you can click it to pick the color. IMO we should update the macro to hide it when the input field is empty.

图片

  1. Clicking in the input box of color chooser or the button itself closes the drop down

This problem does related to the implementation of the drop down, tc-popup-keep should have been added to the class attribute.

Another issue:
If you set the color of a tag through TagManager using new color macro, it will not correctly be displayed on the tag tiddler.
For example change the color of About tiddler

This is because the native HTML color picker does not support CSS color keywords , so we had better create a Field Editor Cascade to input text with a colour-picker macro dropdown.

@kookma
Copy link
Contributor

kookma commented Sep 17, 2024

This square does have function. After you select a color with the native color or input a valid color in the input field on the left, the square shows the color and you can click it to pick the color. IMO we should update the macro to hide it when the input field is empty.

This does not work on Edge or Chrome. Only works on Firefox. I expect to have the dropdown open to see what user has selected.

@Leilei332
Copy link
Contributor Author

This square does have function. After you select a color with the native color or input a valid color in the input field on the left, the square shows the color and you can click it to pick the color. IMO we should update the macro to hide it when the input field is empty.

This does not work on Edge or Chrome. Only works on Firefox. I expect to have the dropdown open to see what user has selected.

Actually it does work on Chrome 128 (After I added tc-popup-keep to the class attribute reveal widget). I think this problem is related to the second one:

动画

I expect to have the dropdown open to see what user has selected.

Colour-picker macro does not support displaying selected color, but the input field below displays color in $:/config/ColourPicker/New. IMO we can create an action for the button to set the content of this tiddler to the colour of the tag.

@pmario
Copy link
Member

pmario commented Sep 18, 2024

@kookma -- you should create a new issue, that links to this one. Merged PRs are listed as "closed". So creating a new issue is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants