-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use colour-picker macro in Tag Manager #8606
Use colour-picker macro in Tag Manager #8606
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
Great thanks @Leilei332 |
@Leilei332 1. move mouse on left side of color chooser what is that clickable square? 2. Clicking in the input box of color chooser or the button itself closes the drop down |
This square does have function. After you select a color with the native color or input a valid color in the input field on the left, the square shows the color and you can click it to pick the color. IMO we should update the macro to hide it when the input field is empty.
This problem does related to the implementation of the drop down,
This is because the native HTML color picker does not support CSS color keywords , so we had better create a Field Editor Cascade to input text with a colour-picker macro dropdown. |
This does not work on Edge or Chrome. Only works on Firefox. I expect to have the dropdown open to see what user has selected. |
Actually it does work on Chrome 128 (After I added
Colour-picker macro does not support displaying selected color, but the input field below displays color in |
@kookma -- you should create a new issue, that links to this one. Merged PRs are listed as "closed". So creating a new issue is the way to go. |
See #8603 .
This require #8605 to display properly.