CLA-individual signed: JC John Sese Cuneta, @techmagus, 2024/10/07 #8668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a workflow that checks to see if the author of a PR has signed the CLA.
The motivation is to make it easier for people looking at https://tiddlywiki.com/ to see what the current version is. As discussed here: https://talk.tiddlywiki.org/t/can-we-put-the-version-of-tw-at-the-top-of-the-hello-there-tiddler/9694 This patch is based on the suggestion by @ericshulman in that forum thread.
…yWiki#8399) The leftover after canceling import operation is deleted now by adding: ``` <$action-deletetiddler $tiddler="$:/state/import/select-all"/> ```
Forgot to activate the tests :/
* Allow width, height and maxZoom to be specified * Add images to city marker tiddlers * Initial support for custom popups * Custom popup templates for the US and Canadian example data * Popups should use the geomap as their parent widget This lets root widget messages work * Typo in default popup template * Clean up the use of popup templates * Allow GeoJSON features to be hidden via a checkbox * Popup template for volcano dataset * Add Natural Earth country data * Optimise marker SVG
These are the changes that have to be done on "master"
…dlyWiki#8423) Deno's node emulation can run TiddlyWiki now that it supports the VM isolates API, but the window global exists in that environment, so both browser and node were being detected, causing the autoboot to trip up on nonexistent argv, as the boot was happening in the constructor right before argv was set. Ref: denoland/deno#19286 Ref: https://github.com/flexdinesh/browser-or-node
A further implementation for TiddlyWiki#8614
This fixes the typo "mediatype" instead of "mediaType" causing a RSOE
Remove plugins that are marked deprecated in full edition
Fix the problem that Polish is not included in the full edition
* remove function wrapper * add back anonymous function to sjcl.tid
* Add tc-table-wrapper class to fix overflow * Apply class in tag manager body
…Wiki#8486) * chore: update editor file import to use procedures and substitute operator * feat: refactor editor file-import UI to reuse filter from $:/config/Editor/EnableImportFilter * feat: support for markdown in editor file import UI * feat: improve markdown type detection and enable markdown image imports by default * fix: uri encode tiddler titles for markdown * escape characters instead of URI encoding * fix: tweak regexp to simplify code and document escaping rules
This reverts commit f4f1ae6.
Signed CLA-individual: JC John Sese Cuneta, @techmagus, 2024/10/07
|
|
|
@techmagus Signatures to the CLA must target the 'tiddlywiki-com' branch. |
|
Hi @techmagus thank you. This PR has somehow inherited all the commits from 'master'. I'm not sure the best way to fix; given it's just the CLA signature it may be safer to make a new PR. |
|
@techmagus -- I think you can edit the "target" branch to master in this PR. Then only 1 file should be changed. If that is not the case, you should create a new PR. |
CLA signatures must be merged to the tiddlywiki-com branch, so I think more may be needed to fix this. |
|
Oh! Thank you. PR 'd the correct one: #8670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed CLA-individual: JC John Sese Cuneta, @techmagus, 2024/10/07