OptimizationChain #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2021 17:54
ecastro98
reviewed
May 12, 2021
ecastro98
previously approved these changes
May 17, 2021
martin-sanjuan
suggested changes
May 30, 2021
| ->once() | ||
| ->andReturn($optimizerChainMock); | ||
|
|
||
| $command = sprintf('convert %s -sampling-factor 4:2:0 -strip -quality 65 %s', $expectedPathToOutput, $expectedPathToOutput); | ||
|
|
||
| $exec = $this->getFunctionMock(__NAMESPACE__, 'shell_exec'); | ||
| $exec | ||
| ->expects($this->once()) | ||
| $exec->expects($this->once()) |
There was a problem hiding this comment.
Aca estoy medio mareado con el core. Las validaciones de cantidad de llamados funcan sin el mockery close del tear down? O habria que agregarlo?
There was a problem hiding this comment.
Es un buen punto, pruebo y te aviso.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom optimizer configurations and build a new default chain