fix(api): return error on failed send_email

Tietokilta · Aug 23, 2024 · 4af68c9 · 4af68c9
1 parent 3851072
commit 4af68c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/api/invoices.rs b/src/api/invoices.rs
@@ -142,11 +142,6 @@ pub async fn create(
             .collect::<Vec<_>>(),
     )?;
 
-    tokio::task::spawn(async move {
-        if let Err(e) = client.send_mail(multipart.data).await {
-            error!("Sending invoice failed: {}", e);
-        }
-    });
-
+    client.send_mail(multipart.data).await?;
     Ok((StatusCode::CREATED, axum::Json(orig)))
 }
diff --git a/src/error.rs b/src/error.rs
@@ -38,7 +38,7 @@ impl IntoResponse for Error {
         error!(%self);
 
         let status = match self {
-            Error::InternalServerError(_) | Error::ReqwestError(_) => {
+            Error::InternalServerError(_) | Error::ReqwestError(_) | Error::TypstError => {
                 StatusCode::INTERNAL_SERVER_ERROR
             }
             Error::JsonError(_)
@@ -47,7 +47,6 @@ impl IntoResponse for Error {
             | Error::MultipartRejection(_)
             | Error::JsonRejection(_)
             | Error::UnsupportedFileFormat(_) => StatusCode::BAD_REQUEST,
-            Error::TypstError => StatusCode::INTERNAL_SERVER_ERROR,
         };
 
         (