Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement ratelimits #4

Closed
lajp opened this issue Jan 26, 2024 · 0 comments · Fixed by #23
Closed

feat: Implement ratelimits #4

lajp opened this issue Jan 26, 2024 · 0 comments · Fixed by #23
Labels
enhancement New feature or request

Comments

@lajp
Copy link
Member

lajp commented Jan 26, 2024

Ratelimits are important for the invoice-submission form so that users cannot abuse the system.
I recommend allowing a few submission per day.
Ratelimits for other endpoints may also be implemented but they aren't as big of a priority as those endpoints will require authentication anyways after #1.

Implementing this could be achieved with tower::limit::rate::RateLimitLayer or then by using governor.

@lajp lajp added the enhancement New feature or request label Jan 26, 2024
@lajp lajp linked a pull request Aug 12, 2024 that will close this issue
15 tasks
@lajp lajp closed this as completed in #23 Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant