Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final touches before a stable release #23

Merged
merged 7 commits into from
Aug 24, 2024
Merged

final touches before a stable release #23

merged 7 commits into from
Aug 24, 2024

Conversation

lajp
Copy link
Member

@lajp lajp commented Aug 12, 2024

After this PR we should be able to bump the version of this project to a stable 1.0.0 and focus on new projects.
Things I'd like to address:

  • Only allow supported attachment files
  • Implement ratelimits for POST /invoices
  • Document the API and make sure everything makes sense
  • Return "OK" from /health
  • Validate IBAN account numbers
  • Add the filenames as labels to the generated pdf to the start of each attached pdf
  • (?) support multiple attachment with the same filename
  • Check for redundant dependencies
  • Return error on failed mail send
  • Improve logging and error handling to the level of a stable product
  • Write tests for the POST /invoices path
  • Make everything (to a reasonable extent) configurable either through a .toml file or through env variable
  • Prevent unnecessary cloning of attachment files
  • Update README and add build instructions
  • Bump version to 1.0.0

Others are also welcome to contribute to this branch either directly or through a PR

@lajp lajp merged commit aaeefc2 into Tietokilta:main Aug 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
1 participant