-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow a wider range of filenames #25
Conversation
This requires the addition of the env variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to add the default host setting to the Dockerfile, otherwise this will not work without infra changes.
This PR improves on filename matching in order to e.g. render .jpeg files as parts of the pdf.
Additionally it disallows unsupported filenames entirely, returing an error if encountered.
This includes the current progress of #23 but is to be merged beforehand in order to get the hotter fixes in ASAP