Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cors headers #24

Merged
merged 2 commits into from
Aug 15, 2024
Merged

feat: add cors headers #24

merged 2 commits into from
Aug 15, 2024

Conversation

tonitert
Copy link
Member

Add cors headers for posting from the tietokilta website. Hardcoded for now, we could also move these to env?

@tonitert tonitert requested a review from lajp as a code owner August 15, 2024 12:10
@lajp
Copy link
Member

lajp commented Aug 15, 2024

Moving them to the env sounds great, however, I'm planning on moving the entire config to a separate .toml file, since everything is a string in the env. Don't bother with the env for now.

Copy link
Member

@lajp lajp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! See the above comment

@tonitert tonitert merged commit d39519d into main Aug 15, 2024
9 checks passed
@lajp lajp deleted the feat/add-cors branch October 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants