This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Added Img support to Markdown, added image formatting as webp #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,7 @@ const markdownComponents: Components = { | |||
| p: P, | |||
| pre: Pre, | |||
| a: A, | |||
| img: Img, | |||
There was a problem hiding this comment.
We should probably add img: Ignore to plainTextComponents as well.
| @@ -1,6 +1,6 @@ | |||
| const parseImageUrl = (url: string) => { | |||
| if (process.env.NODE_ENV === "development") { | |||
| return process.env.STRAPI_URL + url | |||
| return `${process.env.STRAPI_URL + url}?format=webp` | |||
| } | |||
| return url | |||
There was a problem hiding this comment.
If we end up implementing Tietokilta/tikweb-cms#51 or similar in production, we should also add ?format=webp here.
If we do it that way, the image URL will also move to https://<strapi>/uploads, which will require adding STRAPI_URL to each.
| export const Img = ({ className, alt, src, ...props }: ImgProps) => ( | ||
| <img | ||
| alt={alt} | ||
| src={src && parseImageUrl(src)} |
There was a problem hiding this comment.
We should consider supporting srcset here since Strapi provides various sizes of images.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic image support for Markdown. Image formatting as webp, if strapi-plugin-local-image-sharp is installed and working in the backend.