-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Select component #8
base: main
Are you sure you want to change the base?
Conversation
efa647c
to
8fbea6e
Compare
3293594
to
f0676d1
Compare
f0676d1
to
5849c71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a lot of work for just a single component, but it looks fine.
5849c71
to
7f2cadf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7f2cadf
to
7bd5d08
Compare
7bd5d08
to
e662a85
Compare
e662a85
to
fa78cbf
Compare
Other than small touch target, I don't see what's wrong on mobile 🤔 Can you clarify a bit more? |
fa78cbf
to
e36adb7
Compare
Trying to scroll past the top of the list (sometimes also bottom) selects the item where you start the scroll touch. Also some scroll glitchiness visible on the video. az_recorder_20230723_125858.mp4 |
Hmm, this bugginess seems to be present in the original radix-ui component as well. Perhaps we could look for an alternative Select implementation 🤔 This is not a big issue though, when the Select has a more reasonable amount of options. The example is maybe a bit exaggerated 😅 |
No description provided.