test adding encodeURIComponent and decodeURIComponent to revalidate

Tietokilta · Jan 23, 2024 · 4d4181e · 4d4181e
1 parent c2008c5
commit 4d4181e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/apps/cms/src/hooks/revalidate-page.ts b/apps/cms/src/hooks/revalidate-page.ts
@@ -30,9 +30,9 @@ export const revalidatePage =
           const fetchUrl = `${
             process.env.PUBLIC_FRONTEND_URL
           }/next_api/revalidate?${new URLSearchParams({
-            secret: revalidationKey,
-            collection,
-            fetchData,
+            secret: encodeURIComponent(revalidationKey),
+            collection: encodeURIComponent(collection),
+            fetchData: encodeURIComponent(fetchData),
           }).toString()}`;
           req.payload.logger.info(
             `sending revalidate request ${fetchUrl.replace(revalidationKey, "REDACTED")}`,

diff --git a/apps/web/src/app/next_api/revalidate/route.ts b/apps/web/src/app/next_api/revalidate/route.ts
@@ -7,9 +7,15 @@ import { NextResponse } from "next/server";
 // this is to achieve on-demand revalidation of pages that use this data
 // send either `collection` and `slug` or `revalidatePath` as query params
 export function GET(request: NextRequest): NextResponse {
-  const collection = request.nextUrl.searchParams.get("collection");
-  const fetchData = request.nextUrl.searchParams.get("fetchData");
-  const secret = request.nextUrl.searchParams.get("secret");
+  const collection = decodeURIComponent(
+    request.nextUrl.searchParams.get("collection") ?? "",
+  );
+  const fetchData = decodeURIComponent(
+    request.nextUrl.searchParams.get("fetchData") ?? "",
+  );
+  const secret = decodeURIComponent(
+    request.nextUrl.searchParams.get("secret") ?? "",
+  );
 
   if (secret !== process.env.NEXT_REVALIDATION_KEY) {
     // eslint-disable-next-line no-console -- for debugging purposes