Xvnc build cleanup #1770
Merged
Xvnc build cleanup #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VENDOR_RELEASE has been available as a #define since Xorg 1.7, so let's use that and remove all of our custom magic.
Rather than disabling this, make sure the build can find the relevant file.
This has never actually been used, as far as I can tell.
Make things a bit easier to maintain. This style is also more in line with what is being done for other DDX.
Unclear why this was ever needed. libX11 is for X11 clients, and we're building a server.
This hasn't been needed since Xorg 1.16.
Things do not need to be this complicated. We can make sure the VNC extension is always included in a much cleaner way, at least since Xorg 1.16.
Ubuntu 18.04 has been EOL for almost a year, so remove those packages so we can ease our maintenance burden.
No current distribution uses anything older, so let's make things easier for us to maintain.
These are no longer used in the versions of Xorg currently in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of old, annoying crud and bugs in the build system for Xvnc (and libvnc.so).
Try to clean up some of it and make it easier to change things in that corner of the source tree.
This also raises the minimum Xorg requirements to 1.20, since that is what everyone is using these days.