Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vncsession: use /bin/sh if the user shell is not set #1787

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

casantos
Copy link
Contributor

An empty shell field in the password file is valid, although not common. Use /bin/sh in this case, as documented in the passwd(5) man page, since the vncserver script requires a non-empty SHELL environment variable.

Fixes issue #1786.

An empty shell field in the password file is valid, although not common.
Use /bin/sh in this case, as documented in the passwd(5) man page, since
the vncserver script requires a non-empty SHELL environment variable.

Fixes issue TigerVNC#1786.

Signed-off-by: Carlos Santos <[email protected]>
@CendioOssman
Copy link
Member

Ooops. Surprised this wasn't noticed by your enterprise users earlier. :)

@CendioOssman CendioOssman added the bug Something isn't working label Jul 29, 2024
@CendioOssman CendioOssman merged commit 4db34f7 into TigerVNC:master Jul 29, 2024
11 checks passed
@casantos casantos deleted the casantos-issue-1786 branch August 2, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants