Move keyboard handling to separate classes #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might not always be able to map to an RFB key code, so let's use the platform specific code to track which keys are pressed.
CendioOssman
force-pushed
the
keysplit
branch
from
49b0d40 to
82bb4e2
Compare
samhed
approved these changes
Dec 3, 2024
These patches have been sitting around for some time. :) |
This is a general thing so move it in to the core library instead, letting vncviewer focus on just translation of system events to VNC ones.
CendioOssman
force-pushed
the
keysplit
branch
from
82bb4e2 to
0813780
Compare
Encapsulate all the platform specific magic around keyboard in to specific classes, in order to keep the core code more readable.
CendioOssman
force-pushed
the
keysplit
branch
from
0813780 to
7e7e050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate all the platform specific magic around keyboard in to specific classes, in order to keep the core code more readable.