Clean up argument parsing in most commands #1882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These never even had an implementation.
These were barely needed to begin with, and were purged from upstream ages ago.
Let's avoid using special string formats when we can send this data structured instead.
Avoid duplicating this complexity everywhere and make sure all commands get the same handling and fixes.
This was a weird hack just to support the method that split arguments. We don't need this know as we expect callers to do any string handling.
Only one is supposed to be specified, so error out instead of ignoring all but one of the arguments.
Instead of just printing the huge usage text and hoping the user figures out what was wrong.
CendioOssman
force-pushed
the
argparse
branch
from
24f21a4 to
16a9529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly consolidating things around a single implementation. But also some better handling of invalid arguments, mimicing other Unix commands.