Add more high level config parameter types #1910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complain so that the user/developer sees the issue rather than just silently ignoring the problem.
Consolidate validation of enumeration in a central place since this is now a popular type of paramater.
Consolidate handling of a list of values in a single piece of code.
Same as for IntListParameter, consolidate the list handling code to a single place.
We don't do multiple threads on the server, so this is not needed.
Same as IntListParameter and StringListParamter, but for enumerations.
CendioOssman
force-pushed
the
config_types
branch
from
5d2043c to
03dc3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enumerations and lists as explicit types to the configuration system. This makes sure we treat them consistently everywhere, and gives a lot more robustness.