Ensure FIT-to-TCX handles all test files from python-fitparse correctly #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t ALL of its test files The python-fitparse library is a rich source of test files, many of which are not correctly handled by FIT-to-TCX currently.
Almost all of the lap fields can be missing (even end-time!); in these cases we should omit the resulting TCX element entirely, rather than use a default value, and certainly we shouldn't raise an exception due to being unable to convert None to float. Also, some manufacturer and product IDs are not (yet) found in fitparse, and thus only available in numeric form, which must be coerced to string. For an example of both of the above problems, see FIT files generated by recent versions of the Strava Android/iPhone apps.
In some files, perhaps created for non-GPS activities or by non-GPS devices, all timestamps in laps and trackpoints are expressed as integer offsets. (Probably an offset in seconds relative to when the device was turned on.) The only "real" timestamp available is in the 'activity' message field called 'local_timestamp', which represents the device's time in its *local* timezone. To process such files, we must use 'activity.local_timestamp' along with 'activity.timestamp' to calibrate the offset between the integer timestamps and Unix epoch seconds. However, even after doing this we *do not know* the correct timezone for the resulting timestamps. We emphasize this in the ISO8601-format timestamps in the TCX output, by not appending 'Z'. 'tests/files/antfs-dump.63.fit' from dtcooper/python-fitparse is a good example of this issue. It contains data from a heart-rate monitor device without GPS.
'tests/files/Workout*.fit' from dtcooper/python-fitparse are good examples of this.
This setup.py is just a shim to allow local installation from source
("pip install .") to continue working with setuptools<61.0.0.
setuptools(>=61.0.0) adds standalone support for installation from
pyproject.toml only, with no setup.py shim needed (see
https://drivendata.co/blog/python-packaging-2023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
dtcooper/python-fitparseas a submodule so we can test against all of its test files. Many of these were not correctly handled by FIT-to-TCX previously.Then it fixes the resulting issues:
Also, attempting to parse more of the test files explores more of the branches, and thus increases coverage.