Patch config._config, not config.config #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is achieved by deferring the initialization of low-level instances until they are needed and by customizing attribute access for the confg.py module.
Also xfail two consistently failing task graph tests.
ryan-williams
approved these changes
Nov 14, 2024
spencerseale
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Defer loading of cloud.json file This is achieved by deferring the initialization of low-level instances until they are needed and by customizing attribute access for the confg.py module. * Explicitly call both the methods from the original constructor * Fix failing config test, add more notes to config.py. Also xfail two consistently failing task graph tests. * Remove duplicated function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing config test, adds more notes to config.py. Also xfails two task graph tests that have consistently failed this week.
@ihnorton this is the finishing touch on #681.