Fix credentials discrepancy between Bioimaging/VCF and SOMA registration UDFs #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsitsi
reviewed
Dec 4, 2024
There was a problem hiding this comment.
General: From the PR desc I understand that ideally we want the source's access configuration to be different from the destination access config. This would allow registering an asset that was accessed and ingested from a user's namespace to another namespace given we have access to both of them. I had implemented sth similar (if I get the problem right) here #607 feel free to check it out and if not relevant let's sync if I got sth wrong.
gspowley
requested changes
Dec 4, 2024
sgillies
force-pushed
the
sg/sc-58644/moar-credentials
branch
from
db14949 to
f9dfc26
Compare
gspowley
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this would make a difference. I'm able to register an ingested group to my own namespace from my own bucket, but we have trouble registering to the TileDB-Inc namespace from a user bucket. The change I've made here makes SOMA registration exactly the same as others that are observed to work in both cases.
Test ingestions with and without the change are in progress.