Vendor cloudpickle #686
Merged
Vendor cloudpickle #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed by a pickle compatibility test
ihnorton
reviewed
Dec 4, 2024
| @@ -1,6 +1,6 @@ | |||
| attrs==23.2.0 | |||
| certifi==2024.2.2 | |||
| cloudpickle==2.2.1 | |||
| cloudpickle | |||
There was a problem hiding this comment.
@ihnorton I did at one point, and then realized that if tests don't pass with cloudpickle 3 in the environment, we have a major problem. I'm inclined to leave it for now.
|
Again, I went through every failing test at 6bc48b5. They are all explained by tiledb.cloud._vendor.cloudpickle not existing on the server side. |
spencerseale
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Vendor cloudpickle * Install missing cloudpickle test components * Add cloudpickle back to CI requirements Needed by a pickle compatibility test * In module code, import vendored cloudpickle as tdbcp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code now does
from tiledb.cloud._vendor import cloudpickle as tdbcp.