Use enum in ArraySchema for to-be-written Pandas category
#1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #38408: Enumeration attribute incorrectly writes Pandas categorical column. |
ihnorton
approved these changes
Dec 15, 2023
| attr = A.schema.attr(j) | ||
| if attr.enum_label is not None: | ||
| enmr = A.enum(attr.enum_label).values() | ||
| df[attr.name] = df[attr.name].cat.set_categories(enmr) |
There was a problem hiding this comment.
We should probably do this at the arrow level eventually, this is going to be expensive. (sc-38461)
ihnorton
deleted the
viviannguyen/sc-38408/enumeration-attribute-incorrectly-writes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1879 for Python
As reported by @atolopko-czi