-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI job to generate backwards compatibility test indexes and a python unit test to query them #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaosPapailiou
approved these changes
Jan 23, 2024
jparismorgan
added a commit
that referenced
this pull request
Feb 12, 2024
…ython unit test to query them (#206)
jparismorgan
added a commit
that referenced
this pull request
Feb 12, 2024
…ython unit test to query them (#206)
jparismorgan
added a commit
that referenced
this pull request
Feb 12, 2024
…ython unit test to query them (#206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Here we add:
siftmicro_base.fvecs
file which just contains the first 100 vectors fromsiftsmall_base.fvecs
.float32
anduint8
versions of the input data with all available index types (Flat
andIVFFlat
today).backwards-compatibility-data/data/x.x.x
. This is the proposed naming structure:main
.backwards-compatibility-data/data
and verify we can query them.Testing
In this job https://github.com/TileDB-Inc/TileDB-Vector-Search/actions/runs/7558031052/job/20578613117 I tested running this and pushing to
jparismorgan/temp-testing-2
. You can see we make one commit tojparismorgan/temp-testing-2
with the new indices: https://github.com/TileDB-Inc/TileDB-Vector-Search/commits/jparismorgan/temp-testing-2/. I then downloaded these indices and rantest_backwards_compatibility.py
locally and it passed:TODO
I have not yet tested in real release, so I didn't make the CI job a prerequisite for
build_wheels
, but once it's tested it seems like a good thing to do.