Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

somacore 1.0.6 #7

Merged
merged 4 commits into from
Dec 5, 2023
Merged

somacore 1.0.6 #7

merged 4 commits into from
Dec 5, 2023

Conversation

johnkerl
Copy link
Collaborator

@johnkerl johnkerl commented Dec 5, 2023

@johnkerl johnkerl requested review from ihnorton and removed request for Shelnutt2 December 5, 2023 19:25
@thetorpedodog
Copy link

This probably also needs the addition of whatever Conda package provides pyarrow_hotfix.

@johnkerl johnkerl marked this pull request as draft December 5, 2023 19:32
@johnkerl johnkerl marked this pull request as ready for review December 5, 2023 20:01
@johnkerl
Copy link
Collaborator Author

johnkerl commented Dec 5, 2023

@johnkerl johnkerl merged commit e078063 into main Dec 5, 2023
2 checks passed
@jdblischak
Copy link
Contributor

https://anaconda.org/tiledb/somacore/labels

@johnkerl for context, the binary was already built and uploaded from this run on your internal branch. The typical workflow for a conda-forge feedstock is to submit PRs from a fork, because by default any branch can upload. If you prefer using internal branches, we should limit the uploads to main, as we already do in tiledbsoma-feedstock: https://github.com/TileDB-Inc/tiledbsoma-feedstock/blob/4175b10522b7f6e1ac8687b9ab729224b85896a4/conda-forge.yml#L10

Fortunately your early commits failed to build, otherwise the first one would have been uploaded (without the hotfix), and then the final merged version wouldn't have been uploaded (because the build number hadn't changed since the last upload from your branch). I can send a quick PR

@johnkerl
Copy link
Collaborator Author

johnkerl commented Dec 5, 2023

I can send a quick PR

@jdblischak yes I would appreciate that 🙏

It sounds like this repo is broken in a way that I didn't realize, and which is dangerous, and we definitely need it non-broken in the way that tiledbsoma-feedstock is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants