Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at proptest ValueTree for query condition #196

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

rroelke
Copy link
Collaborator

@rroelke rroelke commented Jan 21, 2025

This pull request implements a custom ValueTree for query conditions. This initial pass constructs a ValueTree given a query condition and shrinks the combination clauses.

Without a strategy to generate a query condition, this can only be used to shrink to shrink one that has already identified, e.g.

use strategy_ext::StrategyExt;
Just(my_query_condition).value_tree_map(|vt| QueryConditionValueTree::new(vt.current())

The hope is that this can be useful for customer cases. And someday when we build strategies to generate query conditions it can be useful for shrinking those, too.

@rroelke rroelke requested a review from davisp January 21, 2025 16:29
Copy link
Collaborator

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rroelke rroelke force-pushed the rr/query-condition-strategy-first-pass branch from 644b8ef to 4a0b936 Compare January 21, 2025 17:46
@rroelke rroelke merged commit 6b15a97 into main Jan 21, 2025
3 checks passed
@rroelke rroelke deleted the rr/query-condition-strategy-first-pass branch January 21, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants