Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiledbsoma 1.6.0 pre-release check 1 #64

Closed
wants to merge 5 commits into from
Closed

tiledbsoma 1.6.0 pre-release check 1 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0b2692
tiledbsoma 1.6.0 pre-release check 1
johnkerl Dec 1, 2023
dfa91d0
MNT: Re-rendered with conda-build 3.25.0, conda-smithy 3.30.1, and co…
Dec 1, 2023
0395530
add pyarrow_hotfix
Dec 1, 2023
737f787
pyarrow_hotfix -> pyarrow-hotfix
Dec 1, 2023
e2c396a
code-review feedback
Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .scripts/build_steps.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .scripts/run_osx_build.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 28 additions & 19 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% set name = "tiledbsoma" %}
{% set version = "1.5.1" %}
{% set sha256 = "c3ab7b0ebeec8c9acf99a29a33c269f22db19e5dab6bcf508b2e615f206231e9" %}
{% set version = "1.6.0" %}
{% set sha256 = "tee-bee-dee" %}
# This is the SHA256 of
# TileDB-SOMA-i.j.k.tar.gz
# from
Expand All @@ -12,16 +12,16 @@ package:
name: {{ name }}
version: {{ version }}

source:
url: https://github.com/single-cell-data/TileDB-SOMA/archive/{{ version }}.tar.gz
sha256: {{ sha256 }}
#source:
# url: https://github.com/single-cell-data/TileDB-SOMA/archive/{{ version }}.tar.gz
# sha256: {{ sha256 }}

# Pre-release canary "will Conda be green if we release":
#source:
# git_url: https://github.com/single-cell-data/TileDB-SOMA.git
# git_rev: 41754de2d65960b12378947b8cfe108cd0e6baaa
# git_depth: -1
# # hoping to be 1.5.1 <-- FILL IN HERE
source:
git_url: https://github.com/single-cell-data/TileDB-SOMA.git
git_rev: 8616aa0b0848e356efd343e4cfd28df5e8b94a3f
git_depth: -1
# hoping to be 1.6.0 <-- FILL IN HERE


build:
Expand All @@ -41,11 +41,11 @@ outputs:
- cmake
- make # [not win]
host:
- tiledb >=2.17.4,<2.18
- tiledb >=2.18.2,<2.19
- spdlog
- fmt
run:
- tiledb >=2.17.4,<2.18
- tiledb >=2.18.2,<2.19
- spdlog
- fmt
about:
Expand All @@ -72,7 +72,10 @@ outputs:
- python # [build_platform != target_platform]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
- pybind11 # [build_platform != target_platform]
- pyarrow # [build_platform != target_platform]
# https://github.com/single-cell-data/TileDB-SOMA/issues/1926
- pyarrow <13.0 # [build_platform != target_platform and osx]
- pyarrow # [build_platform != target_platform and not osx]
- pyarrow-hotfix # [build_platform != target_platform]
- numpy # [build_platform != target_platform]
host:
- python
Expand All @@ -86,17 +89,23 @@ outputs:
- setuptools_scm
- wheel
- numpy
- pyarrow
# https://github.com/single-cell-data/TileDB-SOMA/issues/1926
- pyarrow <13.0 # [osx]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the error loading S3 objects described in single-cell-data/TileDB-SOMA#1926 (comment) is a runtime-only error. However, given the complexity of the libarrow run_exports, I agree it is safest to also enforce these pins at build time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdblischak my thoughts exactly

- pyarrow # [not osx]
- pyarrow-hotfix
run:
- {{ pin_compatible('numpy', lower_bound='1.16', upper_bound='1.24') }}
- {{ pin_subpackage('libtiledbsoma', exact=True) }}
- pandas
- pyarrow
# https://github.com/single-cell-data/TileDB-SOMA/issues/1926
- pyarrow <13.0 # [osx]
- pyarrow # [not osx]
- pyarrow-hotfix
- python
- scipy
- anndata <0.10 # [py>37]
- anndata <0.9 # [py<=37]
- tiledb-py >=0.23.4,<0.24.0
- tiledb-py >=0.24.0,<0.25.0
- typing-extensions >=4.1
- numba
- attrs >=22.2
Expand Down Expand Up @@ -133,7 +142,7 @@ outputs:
- r-matrix # [build_platform != target_platform]
- r-bit64 # [build_platform != target_platform]
- r-rcppint64 # [build_platform != target_platform]
- r-tiledb >=0.21.3,<0.22 # [build_platform != target_platform]
- r-tiledb >=0.22.0,<0.23 # [build_platform != target_platform]
- r-arrow # [build_platform != target_platform]
- r-fs # [build_platform != target_platform]
- r-glue # [build_platform != target_platform]
Expand All @@ -149,7 +158,7 @@ outputs:
- r-matrix
- r-bit64
- r-rcppint64
- r-tiledb >=0.21.3,<0.22
- r-tiledb >=0.22.0,<0.23
- r-arrow
- r-fs
- r-glue
Expand All @@ -165,7 +174,7 @@ outputs:
- r-r6
- r-matrix
- r-bit64
- r-tiledb >=0.21.3,<0.22
- r-tiledb >=0.22.0,<0.23
- r-arrow
- r-fs
- r-glue
Expand Down