#126: fix integrated goal and belief revision (#127)

Add missing `this` so that goal revision function
gets updated beliefs

spec/src/agent/Agent.spec.js

@@ -207,4 +207,32 @@ describe('Agent / next(), configuration object-based', () => {
     })
     expect(newAgent.next({ ...Belief('dogNice', true) })[0].action).toEqual('Good dog, Hasso!')
   })
+
+  it('should support integrated goal and belief revision', () => {
+    const beliefs = {
+      ...Belief('dogNice', false)
+    }
+    const goals = {
+      praiseDog: Goal('praiseDog', false, { dogName: 'Hasso' })
+    }
+    const reviseBeliefs = () => {
+      return { dogNice: true }
+    }
+    const reviseGoals = (beliefs, goals) => {
+      if (beliefs.dogNice) {
+        goals.praiseDog.isActive = true
+      }
+      return goals
+    }
+    const plans = [ Plan(goals.praiseDog, (belief, goalValue) => ({ action: `Good dog, ${goalValue.dogName}!` })) ]
+    const newAgent = new Agent({
+      id: 'MyAgent',
+      beliefs,
+      goals,
+      plans,
+      reviseBeliefs,
+      reviseGoals
+    })
+    expect(newAgent.next({ ...Belief('dogNice', false) })[0].action).toEqual('Good dog, Hasso!')
+  })
 })

src/agent/Agent.js

@@ -83,7 +83,7 @@ function Agent (
   this.isActive = true
   this.next = function (beliefs) {
     this.beliefs = this.reviseBeliefs(this.beliefs, beliefs)
-    this.goals = this.reviseGoals(beliefs, this.goals)
+    this.goals = this.reviseGoals(this.beliefs, this.goals)
     if (this.isActive) {
       if (Object.keys(this.desires).length === 0) {
         this.intentions = this.beliefs