Finished implementation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native CI
|
Текущее GUI приложения
|
DmiitriyJarosh
requested changes
May 18, 2022
app/src/main/java/me/timpushkin/sgbmandroidapp/utils/StorageUtils.kt
Outdated
Show resolved
Hide resolved
|
It the last commit some things appeared which I'm not so sure about:
|
DmiitriyJarosh
approved these changes
May 20, 2022
| class StorageUtils(private val context: Context) { | ||
| private val mFileSystem = AndroidFileSystem(context) | ||
|
|
||
| fun copyToCache(uri: Uri, filename: String): File? = |
There was a problem hiding this comment.
We already removed cache? is it useless?
There was a problem hiding this comment.
No, this one is still required. I removed only caching of images, but caching of calibration parameters is still needed: I have to pass a raw file path to the native library, but in the recent versions of Android it is pretty hard (and not recommended) to work with raw paths outside of app-specific directories. That's why I copy the file with parameters to app's cache -- this way I have a safe way to get its path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of the project consisting of the library and a demo application.