Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect upsert workers from input overload #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankmcsherry
Copy link
Member

The upsert.rs operator was doing non-trivial work as it read its input (inserting records into a priority queue). This has the potential to trap workers, who may not be able to retire input as fast as it is produced. Ideally, operators would take a fixed amount of input data (e.g. whatever is available when scheduled) and only do that work, rather than continuing to pull in new data as they run.

This modification makes the workers just drain their inputs without performing work, and then insert the now bounded number of records into the priority queue.

cc: @cirego

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant