Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life updates: non-optional compaction, and Builder::copy. #420

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

frankmcsherry
Copy link
Member

Two changes; I thought there would be more but stopping here for now:

  1. Compaction used to be an optional argument for merging. However, we never use that and it's something of an antipattern (in ye olde days, we only compacted the largest batch in merges).
  2. Added a copy method to Builder allowing for non-owned presentation of tuples. This is especially useful when the destination container does not need to take ownership. Unfortunately we do not retrofit the TupleBulider trait used by trie layers, as they conceal their Item type structure well enough to not support e.g. (&Key, &Val) in place of &(Key, Val).

Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@antiguru antiguru merged commit 42e032d into TimelyDataflow:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants