Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Antichain for MutableAntichain::frontier. #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankmcsherry
Copy link
Member

This PR converts MutableAntichain::frontier from a Vec<T> to an Antichain<T>. In addition to a bit more code reuse, this allows MutableAntichain to expose a &Antichain<T> type rather than an AntichainRef<T>, which can be annoying to relate back to antichains (e.g. to join with, say). One can always go from an &Antichain<T> to an AntichainRef<T> with the borrow() method, but not the other way around.

The downside to scrutinize is the moment where we update frontier rebuilding the antichain. To my eyes, we do almost the same linear work per element, except that we additionally consider evicting elements that we know we wont have to evict. I'm ok losing that performance for the type clarity, or perhaps adding some from_ordered_iter to Antichain.

cc: @jkosh44

Copy link

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just noticing this now, was I supposed to review this? If so, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants