Use Antichain
for MutableAntichain::frontier
.
#485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
MutableAntichain::frontier
from aVec<T>
to anAntichain<T>
. In addition to a bit more code reuse, this allowsMutableAntichain
to expose a&Antichain<T>
type rather than anAntichainRef<T>
, which can be annoying to relate back to antichains (e.g. tojoin
with, say). One can always go from an&Antichain<T>
to anAntichainRef<T>
with theborrow()
method, but not the other way around.The downside to scrutinize is the moment where we update
frontier
rebuilding the antichain. To my eyes, we do almost the same linear work per element, except that we additionally consider evicting elements that we know we wont have to evict. I'm ok losing that performance for the type clarity, or perhaps adding somefrom_ordered_iter
toAntichain
.cc: @jkosh44