Update more core operators #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves more core operators into
core. This includes almost all of the operators of #550, minus some that I think we might want to prune instead (delayandbroadcast). There are other operators that I think are worth retaining (partitionstands out) but several of the remaining operators should probably be pruned.This PR has stronger opinions than #550 on how little should be left for
Stream(vsStreamCore) and they may need to be walked back once there is an alternate container implementation. I think for the moment there is some type inference ease because there is only one implementor, and various annotations that occur in #550 are not needed here (yet). So, perhaps some more convenience methods / trait re-thinks (ToStreamstood out as hard to specify the container type, as it is a trait argument rather than a trait method argument).