Align Bytesable messages to u64
#614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
commented
Dec 27, 2024
Comment on lines
+111
to
+112
| pub trait ExchangeData: Data + encoding::Data + columnar::Columnar { } | ||
| impl<T: Data + encoding::Data + columnar::Columnar> ExchangeData for T { } |
There was a problem hiding this comment.
This .. worked out ok but I realized is from a prior attempt that wanted to columnarize things. Unnecessary for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Bytesabletrait is what indicates how we want to serialize messages, should we need to do that. There is an advantage to data containers beingu64aligned, specifically forcolumnarimplementations but potentially for other implementations. This PR adds up to 7 bytes for each message to ensure that each part ends upu64aligned. With these changes, thecolumnarexample does not need to relocate (memcpy) in order to get aligned data.Tbd: other containers (e.g.
Vec,FlatStack) don't have the same defensive measures in place yet, and we'll want to figure out how to prevent them from messing anything up either. TheirContainerBytesimplementation could do this, or theBytesableimplementation forMessagecould round up once it has serialized everything.