Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assignment.sh based on the feedback #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TinaToronto
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding and removing code

What did you learn from the changes you have made?

Make the changes based on the comments

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

None

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

None

How were these changes tested?

VS

A reference to a related issue in your repository (if applicable)

None

Checklist

  • I can confirm that my changes are working as intended

Yes

@TinaToronto TinaToronto closed this Sep 5, 2024
@TinaToronto TinaToronto reopened this Sep 5, 2024
@TinaToronto
Copy link
Owner Author

Reopen the pull request for the approval.

@TinaToronto TinaToronto closed this Sep 5, 2024
@TinaToronto TinaToronto reopened this Sep 5, 2024
Copy link

@dwz92 dwz92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this, but for better practice next time, don't use cd and simply specify dir2 in your file path

@TinaToronto
Copy link
Owner Author

TinaToronto commented Sep 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants