Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: ConfigQemu. Node, Pool, VmID #3

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Bug fix: ConfigQemu. Node, Pool, VmID #3

merged 3 commits into from
Nov 27, 2023

Conversation

Tinyblargon
Copy link
Owner

Continuation of Telmate/proxmox-api-go#272

Telmate/proxmox-api-go#255 broke ConfigQemu. Node, Pool, VmID

Work Done:

  • Fixed bug 796c3d7
  • Added unit test e4c6e59
  • Changed structure of existing unit test to allow for easier extension 00fba0d. The change was nesting all existing Disk tests into an array item so each top level parameter in ConfigQemu has it's own array entry. This way the item containing the Disk tasks can be collapsed making the test more readable.

@Tinyblargon Tinyblargon self-assigned this Nov 27, 2023
@Tinyblargon Tinyblargon merged commit 21595de into main Nov 27, 2023
1 check passed
@Tinyblargon Tinyblargon deleted the backport-BugFix-Qemu-Pool branch November 28, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tinyblargon Tinyblargon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tinyblargon