TIQR-359: Refactor data module to be used directly in eduid #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 15, 2023 16:53
Multiple factors are now making it imperative for eduid to be dependent solely on the data module i.s.o. core module: * to migrating to AGP 8+ and supporting R8 full mode * replacing kapt with KSP * removing redundant databinding for eduid * migrating localisation to localicious This will help make the integration of the tiqr core into eduid easier and it will be future compatible, i.s.o. still relying on deprecated/redundant or unused dependencies.
Use correct namespace for strings due to migration to AGP 8+
sarahachem
reviewed
Jan 5, 2024
| */ | ||
| fun Context.biometricUsable(): Boolean { | ||
| return BiometricManager.from(this) | ||
| .canAuthenticate(BiometricManager.Authenticators.BIOMETRIC_STRONG) == BiometricManager.BIOMETRIC_SUCCESS |
There was a problem hiding this comment.
reminder, this might not work on Samsung
There was a problem hiding this comment.
Thank you! This is deliberate, the app requires strong biometric authentication, face id is not supported AFAIK. It's fingerprint or nothing
dzolnai
requested changes
Jan 5, 2024
dzolnai
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core module contains view UI which is no longer being used by the eduid app, so keeping the eduid app dependent on core is redundant and needlessly bloats up the app's size.
Therefore, it's best to move the parts from core to the data module so that the eduid app can function without it.
The main changes for this were moving the
ScanComponent, some utility functions and a few string resources.On top of that, a migration to AGP 8+ was made and databinding dependency for the data module is removed (no longer required).