Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add healthcheck to UserStorage, UserSecretStorage and StateStorage classes #54

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add healthcheck to UserStorage, UserSecretStorage and StateStorage classes #54

merged 1 commit into from
Jun 12, 2024

Conversation

pmeulen
Copy link
Contributor

@pmeulen pmeulen commented Jun 5, 2024

@pmeulen pmeulen requested a review from MKodde June 5, 2024 14:27
MKodde
MKodde reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pmeulen PR looks good to me, see my one design related concern. Of which I would not lose any sleep if you decide to leave like this.

Thanks for adding the tests. That's a nice touch!

@pmeulen pmeulen merged commit 2483f2b into develop Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKodde MKodde MKodde left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeulen @MKodde