Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Create unique_ptr variation throws ConnectionException #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tishj
Copy link
Owner

@Tishj Tishj commented Jul 4, 2024

This should remove all need for the:

if (!connection) {
    throw ConnectionException("Connection has already been closed");
}

Which is repeated in many functions and easily overlooked in others, resulting in InternalExceptions instead before.
Now those InternalExceptions have been downgraded to ConnectionException in this area.

Tishj added 2 commits July 4, 2024 22:00
…of an InternalException when it's accessed and it's null
… ConnectionException when it's null (because it was closed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant