Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPF-87-People-Search-Bar #154

Merged
merged 4 commits into from
Sep 24, 2024
Merged

CPF-87-People-Search-Bar #154

merged 4 commits into from
Sep 24, 2024

Conversation

Creaa
Copy link
Collaborator

@Creaa Creaa commented Sep 20, 2024

Task

To run:

  1. Find a new function CREATE OR REPLACE FUNCTION get_employees(...) in seed.sql and run it in SQL Editor.
  2. Go to "$baseroute/cpf/people" and check the list behavior based on search input.
  3. Check the behavior of URL params. When there is text in the input - there should be a parameter "search" if not - then should be removed.

@Creaa Creaa added the enhancement New feature or request label Sep 20, 2024
@Creaa Creaa requested review from skorekm and KrzGruszcz September 20, 2024 14:16
@Creaa Creaa linked an issue Sep 20, 2024 that may be closed by this pull request
@Creaa Creaa self-assigned this Sep 20, 2024
Copy link
Collaborator

@skorekm skorekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, great job!

@KrzGruszcz KrzGruszcz removed their request for review September 24, 2024 09:02
@Creaa Creaa requested a review from skorekm September 24, 2024 09:05
@skorekm skorekm merged commit 83fc2de into develop Sep 24, 2024
4 checks passed
@skorekm skorekm deleted the feature/CPF-87-People-Search-Bar branch September 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] People - Manager POV - Search bar
2 participants