Add onFocus to Semantics widget #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an accessibility issue where the
Pinputwidget would not automatically receive keyboard focus when it received semantic focus. This prevented screen reader users from entering the pin code.Unfortunetly this solution doesn't fix all issues and there is still an issue where if the
Pinputget defocused and focused again using a screen reader the input the user gives is not visible for some reason.The Solution
The fix introduces an
onFocuscallback to theSemanticswidget that wraps the pin input fields. It's similar to how the nativeTextFieldwidget does it.